Allow name_only option gensim downloader api #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c06fbc.
menshikh-iv
suggested changes
Aug 1, 2018
gensim/downloader.py
Outdated
| @@ -29,6 +29,7 @@ | |||
| Also, this API available via CLI:: | |||
|
|
|||
| python -m gensim.downloader --info <dataname> # same as api.info(dataname) | |||
| python -m gensim.downloader --info_name_only # same as api.info(name_only=True) | |||
There was a problem hiding this comment.
better to do it as parameter of --info flag I think (instead of new --info_* flag), like --info name
|
changes made @menshikh-iv |
menshikh-iv
reviewed
Aug 2, 2018
gensim/downloader.py
Outdated
| @@ -29,6 +29,7 @@ | |||
| Also, this API available via CLI:: | |||
|
|
|||
| python -m gensim.downloader --info <dataname> # same as api.info(dataname) | |||
| python -m gensim.downloader --info name_only # same as api.info(name_only=True) | |||
There was a problem hiding this comment.
--info name please :) (but stay name_only parameter for CLI)
|
@aneesh-joshi thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to get the exact names of the models or corpora, a user has to either:
gensim.info()and look through the huge json dump to get the exact namesWhen using gensim-data, I often forget the exact key.
"Was it
'glove-wiki-gigaword'or'glove-gigaword-wiki'?"It would be very helpful if a user could, in the terminal or otherwise, type:
gensim.info(name_only=True)orpython -m gensim.downloader --info_name_onlyans get the following output:
Notes:
The current develop's downloader.py is failing the doctests without me doing anything.